You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
b81c04382b
In the xrx200_close() function we call napi_disable(), that could sleep, with priv->hw->chan[i].lock held. This could lead to deadlock and causes the kernel to complain. Look at the code I couldn't convince myself about why we need to protect that specific code part with the lock. IMHO there seems no reason to protect the refcount variables, because AFAIK ndo_close() and ndo_open() callbacks are already called with a semaphore held. Neither I could figure out why napi_disable() have to be called with that lock held. The only remaining code part for which I could guess the lock is useful for is ltq_dma_close() function call. This patch reduces the lock to the said function call, avoiding the sleep-with-spinlock-held situation Signed-off-by: Andrea Merello <andrea.merello@gmail.com> [fold into 0025-NET-MIPS-lantiq-adds-xrx200-net.patch, backport to kernel 4.4] Signed-off-by: Mathias Kresin <dev@kresin.me> |
7 years ago | |
|---|---|---|
| .. | ||
| adm5120 | 7 years ago | |
| adm8668 | 8 years ago | |
| apm821xx | 7 years ago | |
| ar7 | 7 years ago | |
| ar71xx | 7 years ago | |
| arc770 | 7 years ago | |
| archs38 | 7 years ago | |
| armvirt | 7 years ago | |
| at91 | 7 years ago | |
| ath25 | 7 years ago | |
| au1000 | 8 years ago | |
| bcm53xx | 7 years ago | |
| brcm47xx | 7 years ago | |
| brcm63xx | 7 years ago | |
| brcm2708 | 7 years ago | |
| cns3xxx | 7 years ago | |
| gemini | 7 years ago | |
| generic | 7 years ago | |
| imx6 | 7 years ago | |
| ipq806x | 7 years ago | |
| ixp4xx | 7 years ago | |
| kirkwood | 7 years ago | |
| lantiq | 7 years ago | |
| layerscape | 7 years ago | |
| malta | 7 years ago | |
| mcs814x | 7 years ago | |
| mediatek | 7 years ago | |
| mpc85xx | 7 years ago | |
| mvebu | 7 years ago | |
| mxs | 7 years ago | |
| octeon | 7 years ago | |
| omap | 7 years ago | |
| omap24xx | 7 years ago | |
| orion | 7 years ago | |
| oxnas | 7 years ago | |
| pistachio | 7 years ago | |
| ppc40x | 7 years ago | |
| ppc44x | 7 years ago | |
| ramips | 7 years ago | |
| rb532 | 7 years ago | |
| sunxi | 7 years ago | |
| uml | 7 years ago | |
| x86 | 7 years ago | |
| xburst | 7 years ago | |
| zynq | 7 years ago | |
| Makefile | ||