You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openwrt/package
Jo-Philipp Wich 4a6795409d base-files: functions.sh: fix config_get() on invalid identifiers
When passing a section or option value to config_get() which contains
characters that happen to be valid variable interpolation expressions,
the function returns a nonsensical expression result instead of the
expected empty string.

When the passed section or option name contains other characters which
are not valid within a shell variable name, a substitution error is
occuring instead.

The issue can be easily reproduced by one of the following examples:

    root@OpenWrt:~# . /lib/functions.sh
    root@OpenWrt:~# config load system
    root@OpenWrt:~# config_get variable invalid-section option
    root@OpenWrt:~# echo "$variable"
    section_option:-

    root@OpenWrt:~# . /lib/functions.sh
    root@OpenWrt:~# config load system
    root@OpenWrt:~# config_get variable section invalid-option
    root@OpenWrt:~# echo "$variable"
    option:-

    root@OpenWrt:~# . /lib/functions.sh
    root@OpenWrt:~# config load system
    root@OpenWrt:~# config_get variable section invalid@option
    -ash: eval: syntax error: bad substitution

Fix this issue by only performing interpolations when the given section
and option arguments are free of illegal characters.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
4 years ago
..
base-files base-files: functions.sh: fix config_get() on invalid identifiers 4 years ago
boot ath79/nand: add support for Netgear WNDR4300TN 4 years ago
devel binutils: update to version 2.34 4 years ago
firmware layerscape: harmonize device strings 4 years ago
kernel Revert "procd: update to git HEAD" 4 years ago
libs libubox: update to git HEAD 4 years ago
network dnsmasq: abort when dnssec requested but not available 4 years ago
system procd: update to git HEAD 4 years ago
utils ravpower-mcu: bump PKG_RELEASE 4 years ago
Makefile packages: apply usign padding workarounds to package indexes if needed 5 years ago