You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
30 lines
1.1 KiB
Diff
30 lines
1.1 KiB
Diff
From 8bf13b2aedef0e0ef2250dd612f453e1a923a2d7 Mon Sep 17 00:00:00 2001
|
|
From: Dave Stevenson <dave.stevenson@raspberrypi.org>
|
|
Date: Wed, 13 Feb 2019 12:51:03 +0000
|
|
Subject: [PATCH] staging: mmal-vchiq: If the VPU returns an error,
|
|
don't negate it
|
|
|
|
There is an enum for the errors that the VPU can return.
|
|
port_parameter_get was negating that value, but also using -EINVAL
|
|
from the Linux error codes.
|
|
Pass the VPU error code as positive values. Should the function
|
|
need to pass a Linux failure, then return that as negative.
|
|
|
|
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
|
|
---
|
|
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
--- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
|
|
+++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
|
|
@@ -1400,7 +1400,8 @@ static int port_parameter_get(struct vch
|
|
goto release_msg;
|
|
}
|
|
|
|
- ret = -rmsg->u.port_parameter_get_reply.status;
|
|
+ ret = rmsg->u.port_parameter_get_reply.status;
|
|
+
|
|
/* port_parameter_get_reply.size includes the header,
|
|
* whilst *value_size doesn't.
|
|
*/
|