You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
30 lines
1.1 KiB
Diff
30 lines
1.1 KiB
Diff
From b3cb099f8b0cbe56fcfbb4fb9c7cce48afff41f0 Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Emilio=20L=C3=B3pez?= <emilio@elopez.com.ar>
|
|
Date: Fri, 20 Sep 2013 22:03:10 -0300
|
|
Subject: [PATCH] clk: sunxi: factors: fix off-by-one masks
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The previous code would generate one bit too long masks, and was
|
|
needlessly complicated. This patch replaces it by simpler code that can
|
|
generate the masks correctly.
|
|
|
|
Signed-off-by: Emilio López <emilio@elopez.com.ar>
|
|
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
|
|
---
|
|
drivers/clk/sunxi/clk-factors.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/drivers/clk/sunxi/clk-factors.c
|
|
+++ b/drivers/clk/sunxi/clk-factors.c
|
|
@@ -40,7 +40,7 @@ struct clk_factors {
|
|
|
|
#define to_clk_factors(_hw) container_of(_hw, struct clk_factors, hw)
|
|
|
|
-#define SETMASK(len, pos) (((-1U) >> (31-len)) << (pos))
|
|
+#define SETMASK(len, pos) (((1U << (len)) - 1) << (pos))
|
|
#define CLRMASK(len, pos) (~(SETMASK(len, pos)))
|
|
#define FACTOR_GET(bit, len, reg) (((reg) & SETMASK(len, bit)) >> (bit))
|
|
|