You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
52 lines
2.0 KiB
Diff
52 lines
2.0 KiB
Diff
From 3b902fa811cf6bf7f9ad0ffb77d0a133e0b3bd61 Mon Sep 17 00:00:00 2001
|
|
From: Soeren Moch <smoch@web.de>
|
|
Date: Mon, 1 Jul 2019 12:53:14 +0200
|
|
Subject: [PATCH 09/15] rt2x00usb: remove unnecessary rx flag checks
|
|
|
|
In contrast to the TX path, there is no need to separately read the transfer
|
|
status from the device after receiving RX data. Consequently, there is no
|
|
real STATUS_PENDING RX processing queue entry state.
|
|
Remove the unnecessary ENTRY_DATA_STATUS_PENDING flag checks from the RX path.
|
|
Also remove the misleading comment about reading RX status from device.
|
|
|
|
Suggested-by: Stanislaw Gruszka <sgruszka@redhat.com>
|
|
Signed-off-by: Soeren Moch <smoch@web.de>
|
|
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
|
|
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|
|
---
|
|
drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 9 +++------
|
|
1 file changed, 3 insertions(+), 6 deletions(-)
|
|
|
|
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
|
|
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
|
|
@@ -360,8 +360,7 @@ static void rt2x00usb_work_rxdone(struct
|
|
while (!rt2x00queue_empty(rt2x00dev->rx)) {
|
|
entry = rt2x00queue_get_entry(rt2x00dev->rx, Q_INDEX_DONE);
|
|
|
|
- if (test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags) ||
|
|
- !test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
|
|
+ if (test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
|
|
break;
|
|
|
|
/*
|
|
@@ -400,8 +399,7 @@ static void rt2x00usb_interrupt_rxdone(s
|
|
rt2x00lib_dmadone(entry);
|
|
|
|
/*
|
|
- * Schedule the delayed work for reading the RX status
|
|
- * from the device.
|
|
+ * Schedule the delayed work for processing RX data
|
|
*/
|
|
queue_work(rt2x00dev->workqueue, &rt2x00dev->rxdone_work);
|
|
}
|
|
@@ -413,8 +411,7 @@ static bool rt2x00usb_kick_rx_entry(stru
|
|
struct queue_entry_priv_usb *entry_priv = entry->priv_data;
|
|
int status;
|
|
|
|
- if (test_and_set_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags) ||
|
|
- test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
|
|
+ if (test_and_set_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
|
|
return false;
|
|
|
|
rt2x00lib_dmastart(entry);
|