You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
43ae50978a
https://patchwork.kernel.org/patch/11224189/ -- On 2019-10-28 06:07, wbob wrote: > Hello Roman, > > while reading around drivers/net/wireless/ralink/rt2x00/rt2800lib.c > I stumbled on what I think is an edit of yours made in error in march > 2017: > > https://github.com/torvalds/linux/commit/41977e86#diff-dae5dc10da180f3b055809a48118e18aR5281 > > RT6352 in line 5281 should not have been introduced as the "else if" > below line 5291 can then not take effect for a RT6352 device. Another > possibility is for line 5291 to be not for RT6352, but this seems > very unlikely. Are you able to clarify still after this substantial time? > > 5277: static int rt2800_init_registers(struct rt2x00_dev *rt2x00dev) > ... > 5279: } else if (rt2x00_rt(rt2x00dev, RT5390) || > 5280: rt2x00_rt(rt2x00dev, RT5392) || > 5281: rt2x00_rt(rt2x00dev, RT6352)) { > ... > 5291: } else if (rt2x00_rt(rt2x00dev, RT6352)) { > ... Hence remove errornous line 5281 to make the driver actually execute the correct initialization routine for MT7620 chips. As it was requested by Stanislaw Gruszka remove setting values of MIMO_PS_CFG and TX_PIN_CFG. MIMO_PS_CFG is responsible for MIMO power-safe mode (which is disabled), hence we can drop setting it. TX_PIN_CFG is set correctly in other functions, and as setting this value breaks some devices, rather don't set it here during init, but only modify it later on. Fixes: 41977e86c984 ("rt2x00: add support for MT7620") Reported-by: wbob <wbob@jify.de> Reported-by: Roman Yeryomin <roman@advem.lv> Signed-off-by: Daniel Golle <daniel@makrotopia.org> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com> -- Signed-off-by: Daniel Golle <daniel@makrotopia.org> |
5 years ago | |
|---|---|---|
| .. | ||
| acx-mac80211 | 5 years ago | |
| ar7-atm | 7 years ago | |
| ath10k-ct | 5 years ago | |
| avila-wdt | 7 years ago | |
| brcm2708-gpu-fw | 5 years ago | |
| broadcom-wl | 5 years ago | |
| button-hotplug | 5 years ago | |
| cryptodev-linux | 5 years ago | |
| dtc/patches | 7 years ago | |
| gpio-button-hotplug | 5 years ago | |
| gpio-nct5104d | 6 years ago | |
| hwmon-gsc | 7 years ago | |
| i2c-gpio-custom | 6 years ago | |
| kmod-sched-cake | 5 years ago | |
| lantiq | 5 years ago | |
| leds-apu2 | 6 years ago | |
| linux | 5 years ago | |
| mac80211 | 5 years ago | |
| mt76 | 5 years ago | |
| mwlwifi | 5 years ago | |
| nat46 | 5 years ago | |
| om-watchdog | 5 years ago | |
| rtc-rv5c386a | 7 years ago | |
| rtl8812au-ct | 5 years ago | |
| spi-gpio-custom | 6 years ago | |
| trelay | 5 years ago | |
| w1-gpio-custom | 6 years ago | |