You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
51 lines
2.0 KiB
Diff
51 lines
2.0 KiB
Diff
From patchwork Fri Aug 23 07:09:56 2019
|
|
Content-Type: text/plain; charset="utf-8"
|
|
MIME-Version: 1.0
|
|
Content-Transfer-Encoding: 7bit
|
|
X-Patchwork-Submitter: Stanislaw Gruszka <sgruszka@redhat.com>
|
|
X-Patchwork-Id: 11110703
|
|
X-Patchwork-Delegate: kvalo@adurom.com
|
|
From: Stanislaw Gruszka <sgruszka@redhat.com>
|
|
To: linux-wireless@vger.kernel.org
|
|
Subject: [PATCH] rt2x00: do not set IEEE80211_TX_STAT_AMPDU_NO_BACK on tx
|
|
status
|
|
Date: Fri, 23 Aug 2019 09:09:56 +0200
|
|
Message-Id: <1566544196-20371-1-git-send-email-sgruszka@redhat.com>
|
|
Sender: linux-wireless-owner@vger.kernel.org
|
|
List-ID: <linux-wireless.vger.kernel.org>
|
|
X-Mailing-List: linux-wireless@vger.kernel.org
|
|
|
|
According to documentation IEEE80211_TX_STAT_AMPDU_NO_BACK is suppose
|
|
to be used when we do not recive BA (BlockAck). However on rt2x00 we
|
|
use it when remote station fail to decode one or more subframes within
|
|
AMPDU (some bits are not set in BlockAck bitmap). Setting the flag result
|
|
in sent of BAR (BlockAck Request) frame and this might result of abuse
|
|
of BA session, since remote station can sent BA with incorrect
|
|
sequence numbers after receiving BAR. This problem is visible especially
|
|
when connecting two rt2800 devices.
|
|
|
|
Previously I observed some performance benefits when using the flag
|
|
when connecting with iwlwifi devices. But currently possibly due
|
|
to reacent changes in rt2x00 removing the flag has no effect on
|
|
those test cases.
|
|
|
|
So remove the IEEE80211_TX_STAT_AMPDU_NO_BACK.
|
|
|
|
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
|
|
---
|
|
drivers/net/wireless/ralink/rt2x00/rt2x00dev.c | 3 ---
|
|
1 file changed, 3 deletions(-)
|
|
|
|
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
|
|
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
|
|
@@ -371,9 +371,6 @@ static void rt2x00lib_fill_tx_status(str
|
|
IEEE80211_TX_CTL_AMPDU;
|
|
tx_info->status.ampdu_len = 1;
|
|
tx_info->status.ampdu_ack_len = success ? 1 : 0;
|
|
-
|
|
- if (!success)
|
|
- tx_info->flags |= IEEE80211_TX_STAT_AMPDU_NO_BACK;
|
|
}
|
|
|
|
if (rate_flags & IEEE80211_TX_RC_USE_RTS_CTS) {
|