You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
48 lines
1.6 KiB
Diff
48 lines
1.6 KiB
Diff
From: Russell King <rmk+kernel@armlinux.org.uk>
|
|
Bcc: linux@mail.armlinux.org.uk
|
|
Cc: linux-i2c@vger.kernel.org
|
|
Subject: [PATCH 10/17] i2c: pxa: fix i2c_pxa_scream_blue_murder() debug output
|
|
MIME-Version: 1.0
|
|
Content-Disposition: inline
|
|
Content-Transfer-Encoding: 8bit
|
|
Content-Type: text/plain; charset="utf-8"
|
|
|
|
The IRQ log output is supposed to appear on a single line. However,
|
|
commit 3a2dc1677b60 ("i2c: pxa: Update debug function to dump more info
|
|
on error") resulted in it being printed one-entry-per-line, which is
|
|
excessively long.
|
|
|
|
Fixing this is not a trivial matter; using pr_cont() doesn't work as
|
|
the previous dev_dbg() may not have been compiled in, or may be
|
|
dynamic.
|
|
|
|
Since the rest of this function output is at error level, and is also
|
|
debug output, promote this to error level as well to avoid this
|
|
problem.
|
|
|
|
Reduce the number of always zero prefix digits to save screen real-
|
|
estate.
|
|
|
|
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
|
|
---
|
|
drivers/i2c/busses/i2c-pxa.c | 7 +++----
|
|
1 file changed, 3 insertions(+), 4 deletions(-)
|
|
|
|
--- a/drivers/i2c/busses/i2c-pxa.c
|
|
+++ b/drivers/i2c/busses/i2c-pxa.c
|
|
@@ -364,11 +364,10 @@ static void i2c_pxa_scream_blue_murder(s
|
|
dev_err(dev, "IBMR: %08x IDBR: %08x ICR: %08x ISR: %08x\n",
|
|
readl(_IBMR(i2c)), readl(_IDBR(i2c)), readl(_ICR(i2c)),
|
|
readl(_ISR(i2c)));
|
|
- dev_dbg(dev, "log: ");
|
|
+ dev_err(dev, "log:");
|
|
for (i = 0; i < i2c->irqlogidx; i++)
|
|
- pr_debug("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
|
|
-
|
|
- pr_debug("\n");
|
|
+ pr_cont(" [%03x:%05x]", i2c->isrlog[i], i2c->icrlog[i]);
|
|
+ pr_cont("\n");
|
|
}
|
|
|
|
#else /* ifdef DEBUG */
|