You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
5fd68d60e4
On ath79 and UBNT Bullet M XW (ar9342) I was experiencing weird issues during network setup[1] which I was able to reproduce easily with following commands: uci set network.lan.ipaddr='192.168.1.20' uci commit network ifup lan Which resulted after some time in: ... WARNING: CPU: 0 PID: 0 at net/sched/sch_generic.c:461 dev_watchdog+0x16c/0x280 NETDEV WATCHDOG: eth0 (ag71xx): transmit queue 0 timed out ... Sometimes I wasn't able to use networking anymore, sometimes it was enough to just ifdown/ifup lan and network was backup. On ar71xx it was all working just fine. I've found out, that it was happening because ag71xx_poll() wasn't called, thus the TX queue wasn't emptied. The ag71xx_poll() is being called from napi hrtimer, which is enabled by napi_schedule() in ar71xx_interrupt(), but since no interrupts were ever fired again after ag71xx_stop() was called, it was always leading to tx queue timeouts: *** ag71xx_hard_start_xmit() eth0: packet injected into TX queue eth0: raw intr=00000001 TXPS POLL eth0: enable polling mode eth0: processing TX ring, flush=no eth0: disable polling mode, rx=1, tx=1,limit=32 ( `ifup lan done here` ) *** ag71xx_stop() *** ag71xx_open() *** ag71xx_hw_enable() IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready *** ag71xx_hard_start_xmit() eth0: packet injected into TX queue *** ag71xx_hard_start_xmit() eth0: packet injected into TX queue ... WARNING: CPU: 0 PID: 0 at net/sched/sch_generic.c:320 dev_watchdog+0x164/0x274 So I've looked at ag71xx_stop() in ar71xx, added the missing bits to ath79 and fixed this issue. 1. https://github.com/openwrt/openwrt/pull/1635#issuecomment-448638246 Signed-off-by: Petr Štetiar <ynezz@true.cz> [move ag->link before ag71xx_hw_disable to retain ordering as original] Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com> |
5 years ago | |
|---|---|---|
| .. | ||
| adm5120 | 5 years ago | |
| adm8668 | 5 years ago | |
| apm821xx | 5 years ago | |
| ar7 | 5 years ago | |
| ar71xx | 5 years ago | |
| arc770 | 6 years ago | |
| archs38 | 6 years ago | |
| armvirt | 6 years ago | |
| at91 | 5 years ago | |
| ath25 | 6 years ago | |
| ath79 | 5 years ago | |
| au1000 | 6 years ago | |
| bcm53xx | 5 years ago | |
| brcm47xx | 5 years ago | |
| brcm63xx | 5 years ago | |
| brcm2708 | 5 years ago | |
| cns3xxx | 5 years ago | |
| gemini | 5 years ago | |
| generic | 5 years ago | |
| imx6 | 5 years ago | |
| ipq40xx | 5 years ago | |
| ipq806x | 5 years ago | |
| ixp4xx | 5 years ago | |
| kirkwood | 6 years ago | |
| lantiq | 5 years ago | |
| layerscape | 5 years ago | |
| malta | 6 years ago | |
| mcs814x | 6 years ago | |
| mediatek | 5 years ago | |
| mpc85xx | 5 years ago | |
| mvebu | 5 years ago | |
| mxs | 6 years ago | |
| octeon | 6 years ago | |
| octeontx | 6 years ago | |
| omap | 6 years ago | |
| omap24xx | 7 years ago | |
| orion | 6 years ago | |
| oxnas | 5 years ago | |
| pistachio | 6 years ago | |
| ppc40x | 6 years ago | |
| ppc44x | 6 years ago | |
| ramips | 5 years ago | |
| rb532 | 6 years ago | |
| samsung | 6 years ago | |
| sunxi | 5 years ago | |
| uml | 6 years ago | |
| x86 | 6 years ago | |
| xburst | 6 years ago | |
| zynq | 6 years ago | |
| Makefile | ||