You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
31 lines
1.1 KiB
Diff
31 lines
1.1 KiB
Diff
From 360a1982333c8e8f583663155479115d6eb7cd14 Mon Sep 17 00:00:00 2001
|
|
From: Dan Carpenter <dan.carpenter@oracle.com>
|
|
Date: Mon, 17 Dec 2018 10:08:54 +0300
|
|
Subject: [PATCH] staging: bcm2835-audio: double free in init error
|
|
path
|
|
|
|
commit 136ff5e49271c4c8fceeca5491c48e66b961564b upstream.
|
|
|
|
We free instance here and in the caller. It should be only the caller
|
|
which handles it.
|
|
|
|
Fixes: d7ca3a71545b ("staging: bcm2835-audio: Operate non-atomic PCM ops")
|
|
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
|
|
Reviewed-by: Takashi Iwai <tiwai@suse.de>
|
|
Cc: stable <stable@vger.kernel.org>
|
|
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
---
|
|
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 1 -
|
|
1 file changed, 1 deletion(-)
|
|
|
|
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
|
|
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
|
|
@@ -145,7 +145,6 @@ vc_vchi_audio_init(VCHI_INSTANCE_T vchi_
|
|
dev_err(instance->dev,
|
|
"failed to open VCHI service connection (status=%d)\n",
|
|
status);
|
|
- kfree(instance);
|
|
return -EPERM;
|
|
}
|
|
|