From 8d9627b05b2c33e4468e65739eb7caf9c3f274d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Date: Tue, 10 Dec 2019 12:35:55 +0100 Subject: [PATCH] brcmfmac: set interface carrier to off by default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's important as brcmfmac creates one main interface for each PHY and doesn't allow deleting it. Not setting carrier could result in other subsystems misbehaving (e.g. LEDs "netdev" trigger turning LED on). Signed-off-by: Rafał Miłecki Signed-off-by: Kalle Valo --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -678,6 +678,8 @@ int brcmf_net_attach(struct brcmf_if *if goto fail; } + netif_carrier_off(ndev); + netdev_set_priv_destructor(ndev, brcmf_cfg80211_free_netdev); brcmf_dbg(INFO, "%s: Broadcom Dongle Host Driver\n", ndev->name); return 0;