* rename the offset definition to avoid abiguity with the standard ATA IO address * read and write four bytes at once like the original driver does * use writesl() and readsl() which implicitly iterate over the data This patch assumes buflen to be a multiple of four, which is true for ATA devices. ATAPI support is not known, though unlikely, as the original driver always transfers 512 Bytes at once. Signed-off-by: Phil Sutter Acked-by: Sergei Shtyltov --- --- a/drivers/ata/pata_rb532_cf.c +++ b/drivers/ata/pata_rb532_cf.c @@ -82,13 +82,10 @@ static unsigned int rb532_pata_data_xfer void __iomem *ioaddr = ap->ioaddr.data_addr; int retlen = buflen; - if (write_data) { - for (; buflen > 0; buflen--, buf++) - writeb(*buf, ioaddr); - } else { - for (; buflen > 0; buflen--, buf++) - *buf = readb(ioaddr); - } + if (write_data) + writesl(ioaddr, buf, buflen / sizeof(u32)); + else + readsl(ioaddr, buf, buflen / sizeof(u32)); rb532_pata_finish_io(adev->link->ap); return retlen;