From eb24a57b7ff84242bfb717ce947f9d3e1c0518ee Mon Sep 17 00:00:00 2001 From: Rui Salvaterra Date: Tue, 7 Jul 2020 14:16:47 +0100 Subject: [PATCH] busybox: store applet usage messages uncompressed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The rootfs squashfs is already highly (XZ) compressed. Storing the applet messages in compressed form will increase the entropy and reduce the overall image compression ratio. Size diffs (compressed vs uncompressed): busybox (the executable): 364596 vs 384804 bytes. OpenWrt target images (the kernel image is unchanged, obviously): omnia-medkit-openwrt-mvebu-cortexa9-cznic_turris-omnia-initramfs.tar.gz: 9163597 vs 9162531 bytes (1066 bytes difference). openwrt-mvebu-cortexa9-cznic_turris-omnia-initramfs-kernel.bin: 9161688 vs 9160600 bytes (1088 bytes difference). openwrt-mvebu-cortexa9-cznic_turris-omnia-sysupgrade.img.gz: 9729550 vs 9729230 bytes (320 bytes difference). All in all, we save just a little bit over 1 kiB. As an added bonus, we also don't have to decompress the messages twice, (first from squashfs, then from the bzip2 message storage). Signed-off-by: Rui Salvaterra [added additional size comparision diff detaisl] Signed-off-by: Petr Štetiar --- package/utils/busybox/Config-defaults.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in index 89da7ace8d..29724041f4 100644 --- a/package/utils/busybox/Config-defaults.in +++ b/package/utils/busybox/Config-defaults.in @@ -24,7 +24,7 @@ config BUSYBOX_DEFAULT_FEATURE_VERBOSE_USAGE default y config BUSYBOX_DEFAULT_FEATURE_COMPRESS_USAGE bool - default y + default n config BUSYBOX_DEFAULT_LFS bool default y