From bf5ea2a8dc8397f7b0dd975c06f9fc5dd04cb91b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0tetiar?= Date: Thu, 5 Mar 2020 09:33:52 +0100 Subject: [PATCH] rpcd: fix respawn settings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 432ec292ccc8 ("rpcd: add respawn param") has introduced infinite restarting of the service which could be reached over network. This is not recommended security practice as it might give potential adversary infinite number of tries in case there might be some issue in the rpcd or its surrounding stack. So lets remove the currently bogus `respawn_retry` variable (it wasn't possible to override it anyway), reverting to the previous default max. of 5 service restarts which could be now overriden via system's UCI settings if desired. Cc: Jo-Philip Wich Cc: Florian Eckert Cc: Hauke Mehrtens Fixes: 432ec292ccc8 ("rpcd: add respawn param") Signed-off-by: Petr Štetiar (cherry picked from commit 52e6fb13692986c76fd32159fb9fc82d712a5c3f) --- package/system/rpcd/files/rpcd.init | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/system/rpcd/files/rpcd.init b/package/system/rpcd/files/rpcd.init index b1061b906c..4c701a28e6 100755 --- a/package/system/rpcd/files/rpcd.init +++ b/package/system/rpcd/files/rpcd.init @@ -12,7 +12,7 @@ start_service() { procd_open_instance procd_set_param command "$PROG" ${socket:+-s "$socket"} ${timeout:+-t "$timeout"} - procd_set_param respawn ${respawn_retry:-0} + procd_set_param respawn procd_close_instance }