From 6648e9458f2f47cdbe16bd9537f08048a0a252fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0tetiar?= Date: Sun, 14 Apr 2019 17:26:04 +0200 Subject: [PATCH] ath79: set mib-poll-interval on mdio0 attached ar83xx switch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit "generic: ar8216: add mib_poll_interval switch attribute" sets mib-poll-interval as disabled by default (was set to 2s), so it makes switch LEDs trigger disfunctional on devices which don't have mib-poll-interval set. So this patch sets mib-poll-interval to 500ms on devices which have ar83xx switch connected to mdio0 bus, as the same value was set for built in switches in 443fc9ac35 ("ath79: use ar8216 for builtin switch"). Some measurements performed on TP-Link Archer C7-v5: mib-type=0, mib-poll-interval=500ms (10s pidstat) Average: %usr %system %guest %wait %CPU CPU Command Average: 0.00 1.93 0.00 0.00 1.93 - kworker/0:2 iperf3 (30s): 334 Mbits/sec mib-type=0, mib-poll-interval=2s (10s pidstat) Average: %usr %system %guest %wait %CPU CPU Command Average: 0.00 1.14 0.00 0.00 1.14 - kworker/0:2 iperf3 (30s): 334 Mbits/sec So it seems like we get 4x faster LED refresh rate for additional 0.8% CPU load. Signed-off-by: Petr Štetiar --- target/linux/ath79/dts/qca9563_dlink_dir-859-a1.dts | 1 + target/linux/ath79/dts/qca9563_tplink_archer-c2-v3.dts | 1 + target/linux/ath79/dts/qca9563_tplink_archer-c7-v4.dts | 1 + target/linux/ath79/dts/qca9563_tplink_archer-x6-v2.dtsi | 1 + target/linux/ath79/dts/qca9563_tplink_archer-x7-v5.dtsi | 1 + target/linux/ath79/dts/qca9563_tplink_tl-wr1043n.dtsi | 1 + 6 files changed, 6 insertions(+) diff --git a/target/linux/ath79/dts/qca9563_dlink_dir-859-a1.dts b/target/linux/ath79/dts/qca9563_dlink_dir-859-a1.dts index 23b4cc5126..8bd9067afa 100644 --- a/target/linux/ath79/dts/qca9563_dlink_dir-859-a1.dts +++ b/target/linux/ath79/dts/qca9563_dlink_dir-859-a1.dts @@ -149,6 +149,7 @@ phy0: ethernet-phy@0 { reg = <0>; phy-mode = "sgmii"; + qca,mib-poll-interval = <500>; qca,ar8327-initvals = < 0x04 0x00080080 /* PORT0 PAD MODE CTRL */ diff --git a/target/linux/ath79/dts/qca9563_tplink_archer-c2-v3.dts b/target/linux/ath79/dts/qca9563_tplink_archer-c2-v3.dts index 7a88f56a02..ebc9177a39 100644 --- a/target/linux/ath79/dts/qca9563_tplink_archer-c2-v3.dts +++ b/target/linux/ath79/dts/qca9563_tplink_archer-c2-v3.dts @@ -159,6 +159,7 @@ phy0: ethernet-phy@0 { reg = <0>; phy-mode = "sgmii"; + qca,mib-poll-interval = <500>; qca,ar8327-initvals = < 0x04 0x00080080 /* PORT0 PAD MODE CTRL */ diff --git a/target/linux/ath79/dts/qca9563_tplink_archer-c7-v4.dts b/target/linux/ath79/dts/qca9563_tplink_archer-c7-v4.dts index db8869cf16..b278c9304b 100644 --- a/target/linux/ath79/dts/qca9563_tplink_archer-c7-v4.dts +++ b/target/linux/ath79/dts/qca9563_tplink_archer-c7-v4.dts @@ -245,6 +245,7 @@ phy0: ethernet-phy@0 { reg = <0>; phy-mode = "sgmii"; + qca,mib-poll-interval = <500>; qca,ar8327-initvals = < 0x04 0x80080080 /* PORT0 PAD MODE CTRL */ diff --git a/target/linux/ath79/dts/qca9563_tplink_archer-x6-v2.dtsi b/target/linux/ath79/dts/qca9563_tplink_archer-x6-v2.dtsi index 37ab16453b..ac10d9134a 100644 --- a/target/linux/ath79/dts/qca9563_tplink_archer-x6-v2.dtsi +++ b/target/linux/ath79/dts/qca9563_tplink_archer-x6-v2.dtsi @@ -146,6 +146,7 @@ phy0: ethernet-phy@0 { reg = <0>; phy-mode = "sgmii"; + qca,mib-poll-interval = <500>; qca,ar8327-initvals = < 0x04 0x00080080 /* PORT0 PAD MODE CTRL */ diff --git a/target/linux/ath79/dts/qca9563_tplink_archer-x7-v5.dtsi b/target/linux/ath79/dts/qca9563_tplink_archer-x7-v5.dtsi index 6e1d5d9b09..324d831249 100644 --- a/target/linux/ath79/dts/qca9563_tplink_archer-x7-v5.dtsi +++ b/target/linux/ath79/dts/qca9563_tplink_archer-x7-v5.dtsi @@ -156,6 +156,7 @@ phy0: ethernet-phy@0 { reg = <0>; phy-mode = "sgmii"; + qca,mib-poll-interval = <500>; qca,ar8327-initvals = < 0x04 0x80080080 /* PORT0 PAD MODE CTRL */ diff --git a/target/linux/ath79/dts/qca9563_tplink_tl-wr1043n.dtsi b/target/linux/ath79/dts/qca9563_tplink_tl-wr1043n.dtsi index c778cf90ba..42b4b6b8c6 100644 --- a/target/linux/ath79/dts/qca9563_tplink_tl-wr1043n.dtsi +++ b/target/linux/ath79/dts/qca9563_tplink_tl-wr1043n.dtsi @@ -103,6 +103,7 @@ phy0: ethernet-phy@0 { reg = <0>; phy-mode = "sgmii"; + qca,mib-poll-interval = <500>; qca,ar8327-initvals = < 0x04 0x00080080 /* PORT0 PAD MODE CTRL */